Browse Source

Fix small grammar issues in ms08_067 and ms17_010

Also includes very small changes to improve punctuation consistency
within CONTRIBUTING.md
Brady Sullivan 1 year ago
parent
commit
593813cdef

+ 4
- 4
CONTRIBUTING.md View File

@@ -45,8 +45,8 @@ and Metasploit's [Common Coding Mistakes].
45 45
 * **Do** specify a descriptive title to make searching for your pull request easier.
46 46
 * **Do** include [console output], especially for witnessable effects in `msfconsole`.
47 47
 * **Do** list [verification steps] so your code is testable.
48
-* **Do** [reference associated issues] in your pull request description
49
-* **Do** write [release notes] once a pull request is landed
48
+* **Do** [reference associated issues] in your pull request description.
49
+* **Do** write [release notes] once a pull request is landed.
50 50
 * **Don't** leave your pull request description blank.
51 51
 * **Don't** abandon your pull request. Being responsive helps us land your code faster.
52 52
 
@@ -58,8 +58,8 @@ Pull requests [PR#2940] and [PR#3043] are a couple good examples to follow.
58 58
   - It would be even better to set up `msftidy.rb` as a [pre-commit hook].
59 59
 * **Do** use the many module mixin [API]s. Wheel improvements are welcome; wheel reinventions, not so much.
60 60
 * **Don't** include more than one module per pull request.
61
-* **Do** include instructions on how to setup the vulnerable environment or software
62
-* **Do** include [Module Documentation](https://github.com/rapid7/metasploit-framework/wiki/Generating-Module-Documentation) showing sample run-throughs
61
+* **Do** include instructions on how to setup the vulnerable environment or software.
62
+* **Do** include [Module Documentation](https://github.com/rapid7/metasploit-framework/wiki/Generating-Module-Documentation) showing sample run-throughs.
63 63
 
64 64
 
65 65
 

+ 4
- 4
documentation/modules/exploit/windows/smb/ms08_067_netapi.md View File

@@ -1,7 +1,7 @@
1 1
 ms08_067_netapi is one of the most popular remote exploits against Microsoft Windows. It is
2
-considered a reliable exploit, and allows you to gain access as SYSTEM - the highest Windows
3
-privilege. In modern day penetration test, this exploit would most likely be used in an internal
4
-environment, and not so much from external due to the likelihood of a firewall.
2
+considered a reliable exploit and allows you to gain access as SYSTEM - the highest Windows
3
+privilege. In modern day penetration tests, this exploit would most likely be used in an internal
4
+environment and not so much from external due to the likelihood of a firewall.
5 5
 
6 6
 The check command of ms08_067_netapi is also highly accurate, because it is actually testing the
7 7
 vulnerable code path, not just passively.
@@ -15,7 +15,7 @@ This exploit works against a vulnerable SMB service from one of these Windows sy
15 15
 * Windows XP
16 16
 * Windows 2003
17 17
 
18
-To reliability determine whether the machine is vulnerable, you will have to either examine
18
+To reliably determine whether the machine is vulnerable, you will have to either examine
19 19
 the system's patch level, or use a vulnerability check.
20 20
 
21 21
 ## Verification Steps

+ 2
- 2
documentation/modules/exploit/windows/smb/ms17_010_eternalblue.md View File

@@ -1,7 +1,7 @@
1 1
 ms17_010_eternalblue is a remote exploit against Microsoft Windows, originally written by the
2 2
 Equation Group (NSA) and leaked by Shadow Brokers (an unknown hacking entity). It is
3
-considered a reliable exploit, and allows you to gain access not only as SYSTEM - the highest Windows
4
-user mode privilege, but also full control of the kernel in ring 0. In modern day penetration test,
3
+considered a reliable exploit and allows you to gain access not only as SYSTEM - the highest Windows
4
+user mode privilege, but also full control of the kernel in ring 0. In modern day penetration tests,
5 5
 this exploit can be found in internal and external environments.
6 6
 
7 7
 As far as remote kernel exploits go, this one is highly reliable and safe to use.

Loading…
Cancel
Save