#20 custom layouts won't survive theme upgrade process

Open
opened 1 year ago by tkalpakidis · 7 comments

Could you please make custom layouts immutable to upgrade process?

Here is my tree https://pastebin.com/vQ2P8nXc

In this example custom layout page is named noise

First issue: Adding custom layouts under SITE-ROOT/layouts is not enough because the site won’t build (hugo errors looking for partials path) until we add theme under SITE-ROOT/themes/after-dark/layouts/partials

Second issue: HoM won’t work unless we put custom layouts under SITE-ROOT/themes/hall-of-mirrors/layouts

My tree shown in pastebin is actually working but we need to kick custom layouts out of theme’s folders in order to survive an upgrade process

Could you please make custom layouts immutable to upgrade process? Here is my tree https://pastebin.com/vQ2P8nXc In this example custom layout page is named **_noise_** First issue: Adding custom layouts under `SITE-ROOT/layouts` is not enough because the site won't build (hugo errors looking for partials path) until we add theme under `SITE-ROOT/themes/after-dark/layouts/partials` Second issue: HoM won't work unless we put custom layouts under `SITE-ROOT/themes/hall-of-mirrors/layouts` My tree shown in pastebin is actually working but we need to kick custom layouts out of theme's folders in order to survive an upgrade process
tkalpakidis commented 1 year ago
Poster

I can has our base back pleaz??
;)

I can has our base back pleaz?? ;)
jhabdas commented 1 year ago
Owner

:) yes, absolutely. will look to fix today soon

:) yes, absolutely. will look to fix <del>today</del> <ins><a href="https://git.habd.as/comfusion/after-dark/issues/7">soon</a></ins>
jhabdas added the
enhancement
label 1 year ago
jhabdas added this to the 0.3.0 milestone 1 year ago
tkalpakidis changed title from custom layouts won't survive theme upgrade process :( to custom layouts won't survive theme upgrade process 1 year ago
jhabdas commented 1 year ago
Owner

@tkalpakidis could you share your hugo version or Dockerfile, if present so I can finagle the generator to ensure it’s not a packaging issue with the Hugo binary? After reviewing the OP I think this may be related to a blocker I ran into in https://git.habd.as/comfusion/after-dark/issues/29

Thanks for your patience.

@tkalpakidis could you share your `hugo version` or `Dockerfile`, if present so I can finagle the generator to ensure it's not a packaging issue with the Hugo binary? After reviewing the OP I think this may be related to a blocker I ran into in https://git.habd.as/comfusion/after-dark/issues/29 Thanks for your patience.
jhabdas commented 1 year ago
Owner

Things to consider with resolution:

  • Add some sensible defaults so the module will function without add’l config
  • Refactor logic for inclusion of module into the module itself.
Things to consider with resolution: - [ ] Add some sensible defaults so the module will function without add'l config - [ ] Refactor logic for inclusion of module into the module itself.
tkalpakidis commented 1 year ago
Poster

it’s been a while but, hey here is my hugo version anywayz Hugo Static Site Generator v0.46

it's been a while but, hey here is my hugo version anywayz Hugo Static Site Generator v0.46
tkalpakidis commented 1 year ago
Poster

for the time being i just backup/restore my custom layouts before/after upgrades It is actually two folders one under themes/after-dark/layout and the other under themes/after-dark/layout/partials

for the time being i just backup/restore my custom layouts before/after upgrades It is actually two folders one under themes/after-dark/layout and the other under themes/after-dark/layout/partials
jhabdas commented 1 year ago
Owner

Thanks. This is still on my radar. Will tackle after mining proxy. Thanks for the workaround and your patience.

Thanks. This is still on my radar. Will tackle after mining proxy. Thanks for the workaround and your patience.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.