Browse Source

Correct misconception about GC only deleting namespaced resources

Alfonso Acosta 8 months ago
parent
commit
ddc1ee1d02
2 changed files with 4 additions and 5 deletions
  1. 3
    4
      CHANGELOG.md
  2. 1
    1
      cluster/kubernetes/sync_test.go

+ 3
- 4
CHANGELOG.md View File

@@ -6,10 +6,9 @@ operator is in [./CHANGELOG-helmop.md](./CHANGELOG-helmop.md).
6 6
 This release comes with experimental garbage collection and Git commit signing:
7 7
 
8 8
 1. Experimental garbage collection of cluster resources. When providing the
9
-   `--sync-garbage-collection` flag, namespace-scoped cluster resources no
10
-   longer existing in Git will be removed. Read the
11
-   [garbage collection documentation](site/garbagecollection.md) for further
12
-   details.
9
+   `--sync-garbage-collection` flag, cluster resources no longer existing in Git 
10
+   will be removed. Read the [garbage collection documentation](site/garbagecollection.md) 
11
+   for further details.
13 12
 
14 13
 2. [GPG](https://en.wikipedia.org/wiki/GNU_Privacy_Guard)
15 14
    [Git commit signing](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt--Sltkeyidgt),

+ 1
- 1
cluster/kubernetes/sync_test.go View File

@@ -332,7 +332,7 @@ metadata:
332 332
 		test(t, kube, "", "", false)
333 333
 	})
334 334
 
335
-	t.Run("sync won't delete non-namespaced resources", func(t *testing.T) {
335
+	t.Run("sync won't incorrectly delete non-namespaced resources", func(t *testing.T) {
336 336
 		kube, _ := setup(t)
337 337
 		kube.GC = true
338 338
 

Loading…
Cancel
Save