#46 Accept nonstandard autocomplete value

Closed
opened 1 year ago by jhabdas · 1 comments
jhabdas commented 1 year ago

Autocomplete on forms does not deactivate with false as it’s a nonstandard value. See what happens in browsers when it’s added. If it works anyway let it through otherwise treat it like off.

Look at form component, textinput and textarea.

Autocomplete on forms does not deactivate with `false` as it's a nonstandard value. See what happens in browsers when it's added. If it works anyway let it through otherwise treat it like `off`. Look at `form` component, `textinput` and `textarea`.
jhabdas added the
enhancement
label 1 year ago
jhabdas commented 1 year ago
Owner

Rather than treating a non-standard autocomplete value as "off" form control shortcode will instead alert the user of the error and attempt[^1] to fail the build until it’s corrected. In the case of a partial no error will be presented and the invalid value quietly scrubbed from the output.

[^1]: Tested in Hugo 0.46 doesn’t fail the build on errorf as stated in the docs but that’s okay because it still outputs to stdout and the big red alert ought to be reasonably obvious something’s not quite right.

Rather than treating a non-standard `autocomplete` value as `"off"` form control shortcode will instead alert the user of the error and attempt[^1] to fail the build until it's corrected. In the case of a partial no error will be presented and the invalid value quietly scrubbed from the output. [^1]: Tested in Hugo `0.46` doesn't fail the build on `errorf` [as stated](https://gohugo.io/functions/errorf/) in the docs but that's okay because it still outputs to `stdout` and the big red alert ought to be reasonably obvious something's not quite right.
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.