#4 Javascript dependencies don't load in dev with path in `baseurl`

Closed
opened 1 year ago by corylogan · 3 comments
corylogan commented 1 year ago

I noticed that the lazysizes.js fails to load with a 404, and discovered that it was because I have a baseurl defined in my config.toml.

My hugo site is served from a sub-directory, which is why i define the baseurl, but in dev, it simply fails to load the JS with a 404.

I noticed that the `lazysizes.js` fails to load with a 404, and discovered that it was because I have a `baseurl` defined in my `config.toml`. My hugo site is served from a sub-directory, which is why i define the `baseurl`, but in dev, it simply fails to load the JS with a 404.
jhabdas commented 1 year ago
Owner

Thanks for spotting that! I’ll get a fix in for it my day tomorrow. Meanwhile here’s the file to override in your theme as a workaround:

558307f222/layouts/partials/async-scripts.html

Thanks for spotting that! I'll get a fix in for it my day tomorrow. Meanwhile here's the file to override in your theme as a workaround: https://git.habd.as/comfusion/after-dark/src/commit/558307f2228edf9ec916686673549d8981cdab98/layouts/partials/async-scripts.html
jhabdas added the
bug
label 1 year ago
corylogan commented 1 year ago
Poster

Thanks, the override works! Also, thanks for this great theme! I’ve been enjoying it for the past year.

Thanks, the override works! Also, thanks for this great theme! I've been enjoying it for the past year.
jhabdas commented 1 year ago
Owner

Glad to hear that. Fixed in 4.0.2. Please let me know if you have any issues. Enjoy the performance boost!

Glad to hear that. Fixed in [`4.0.2`](https://git.habd.as/comfusion/after-dark/src/branch/master/CHANGELOG.md#402-2018-07-18). Please let me know if you have any issues. Enjoy the performance boost!
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.