#25 BusyBox install error

Closed
opened 1 year ago by jhabdas · 1 comments
jhabdas commented 1 year ago

When the quick installer was updated to pull the latest theme version from NPM before downloading I added feature detection on grep to compensate for differences in flags between BSD and GNU grep. The check looks at the binary version by calling grep --version which isn’t available on BusyBox grep used by Termux on Android. As a result, the script needs to be updated to check for BusyBox which uses the E flag.

Note BusyBox uses bash-4.4 so recursive globbing is possible with shopt -s globstar, if desirable.

When the quick installer was updated to pull the latest theme version from NPM before downloading I added feature detection on `grep` to compensate for differences in flags between BSD and GNU grep. The check looks at the binary version by calling `grep --version` which isn't available on BusyBox grep used by Termux on Android. As a result, the script needs to be updated to check for BusyBox which uses the `E` flag. Note BusyBox uses `bash-4.4` so recursive globbing is possible with `shopt -s globstar`, if desirable.
jhabdas added the
bug
label 1 year ago
jhabdas commented 1 year ago
Owner

Opened question on Super User to see if there’s a way to clean up the code while restoring BusyBox support. Looking at man grep seems egrep may eliminate the need to use branch logic when doing the pattern matching to find the theme version.

Opened [question](https://superuser.com/questions/1346834/detecting-version-of-grep) on Super User to see if there's a way to clean up the code while restoring BusyBox support. Looking at `man grep` seems `egrep` may eliminate the need to use branch logic when doing the pattern matching to find the theme version.
jhabdas self-assigned this 1 year ago
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.